Merged
Conversation
Contributor
|
PR missing one of the required labels: {'dependencies', 'breaking-change', 'new feature', 'internal', 'ci', 'documentation', 'bug', 'api-sync', 'enhancement'} |
26 tasks
| assert False, "Expected exception" | ||
| except: | ||
| pass | ||
|
|
Contributor
There was a problem hiding this comment.
I believe it's more idiomatic in python to use https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises but as I look in the surrounding code, you're pretty much following the existing convention in the code. It'd be too much work to convert this all to use the unittest lib and probably not worth the effort for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update eclipse-zenoh/zenoh#2392 removes rust 1.75 requirement.
Added test for build without cargo.lock and bumbed to rust 1.93